FishEye 2.2.1

committed 2335 to HERAS-AF_XACML

16 Jul

UNDER REVIEW - issue HERASAFXACMLCORE-99: PolicyRepository should be split into two interfaces
http://jira.herasaf.org/browse/HERASAFXACMLCORE-99

Includes also issues from task HERASAFXACML-131

changed 16 java files

Florian Huonder

summarized and closed HERAS-AF-XACML-19

16 Jul

ok

Florian Huonder

summarized and closed HERAS-AF-XACML-18

16 Jul

ok

Stefan Oberholzer

finished reviewing HERAS-AF-XACML-18

16 Jul

Florian Huonder

summarized and closed HERAS-AF-XACML-16

16 Jul

Ok.

Stefan Oberholzer

finished reviewing HERAS-AF-XACML-16

16 Jul

Stefan Oberholzer

finished reviewing HERAS-AF-XACML-19

16 Jul

Florian Huonder

started review HERAS-AF-XACML-19

12 Jul

UNDER REVIEW - issue HERASAFXACMLCORE-137: Introduce custom return value for TargetMatcher

Florian Huonder

committed 2319 to HERAS-AF_XACML HERAS-AF-XACML-19

12 Jul

UNDER REVIEW - issue HERASAFXACMLCORE-137: Introduce custom return value for TargetMatcher
http://jira.herasaf.org/browse/HERASAFXACMLCORE-137

changed 14 java files

Florian Huonder

committed 2316 to HERAS-AF_XACML HERAS-AF-XACML-16

12 Jul

UNDER REVIEW - issue HERASAFXACMLCORE-129: Introduce StatusCode interface
http://jira.herasaf.org/browse/HERASAFXACMLCORE-129

changed 21 java files

Florian Huonder

started review HERAS-AF-XACML-16

12 Jul

UNDER REVIEW - issue HERASAFXACMLCORE-129: Introduce StatusCode interface

Florian Huonder

started summarizing HERAS-AF-XACML-16

12 Jul

Florian Huonder

started review HERAS-AF-XACML-18

12 Jul

UNDER REVIEW - issue HERASAFXACMLCORE-31: IPv4Address accepts invalid IP-Addresses

Florian Huonder

committed 2315 to HERAS-AF_XACML HERAS-AF-XACML-18

12 Jul

UNDER REVIEW - issue HERASAFXACMLCORE-31: IPv4Address accepts invalid IP-Addresses
http://jira.herasaf.org/browse/HERASAFXACMLCORE-31

changes from review done.

deleted from TestIPv4Address.java

trunk/herasaf-xacml-core/src/test/java/org/herasaf/xacml/core/types/test/TestIPv4Address.java (+0 -1)
- Diff
- View
- File History
- Download

Florian Huonder

committed 2314 to HERAS-AF_XACML

12 Jul

UNDER REVIEW - issue HERASAFXACMLCORE-31: IPv4Address accepts invalid IP-Addresses
http://jira.herasaf.org/browse/HERASAFXACMLCORE-31

changes from review done.

modified TestIPv4Address.java

trunk/herasaf-xacml-core/src/test/java/org/herasaf/xacml/core/types/test/TestIPv4Address.java (+5 -2)
- Diff
- View
- File History
- Download

Florian Huonder

started summarizing HERAS-AF-XACML-18

12 Jul

Florian Huonder

summarized and closed HERAS-AF-XACML-17

12 Jul

Review OK.

Stefan Oberholzer

commented on HERAS-AF-XACML-18

11 Jul

The cases containing 255 are never Tested. There should be also test cases for this.

Stefan Oberholzer

commented on HERAS-AF-XACML-18

11 Jul

The original exception is hidden, which makes it harder to check why the test fails. The exception should just be rethrown in the else case. The rest is handled correctly by TestNG.

Stefan Oberholzer

commented on HERAS-AF-XACML-18

11 Jul

The cases 1.256.1.1 and 1.1.256.1 should be tested too.

Stefan Oberholzer

commented on HERAS-AF-XACML-16

11 Jul

This method does not allow to handle the customer status codes.
The only way he can adapt to this is by overriding the Evaluation Context. and re-implement the full method.

I think this can be done better when the code to check which statuscode overrules is moved to the enum. e.g.

this.code =(! (code instanceof XACMLDefaultStatusCode) ) ? code.getOverrulingCode(this.code): this.code.getOverrulingCode(this);

A side effect of this is a better design, as the rules which status code is stronger is moved to the status code.

It may also be a good idea to give the status codes an ordering. This would allow to implement this in one line. E.g. return (newCode.severity > this.severity) ? newCode : this;

Stefan Oberholzer